Skip to content

Don't auto change to svg namespace when in foreign namespace #6261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2021
Merged

Don't auto change to svg namespace when in foreign namespace #6261

merged 2 commits into from
Apr 30, 2021

Conversation

halfnelson
Copy link
Contributor

@halfnelson halfnelson commented Apr 29, 2021 •
edited
Loading

Prevents unwanted namespace change inside of foreign namespaces for element names matching those in svg's namespace #6257
which breaks svelte-nodegui

Tests

  • Run the tests with npm test and lint the project with npm run lint

shirakaba
shirakaba approved these changes Apr 30, 2021
View reviewed changes
Copy link

@shirakaba shirakaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me!

@Conduitry Conduitry merged commit 4633697 into sveltejs:master Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@shirakaba shirakaba shirakaba approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@halfnelson @shirakaba @Conduitry